From 18b4714e38d4871947eff0acb7f1c8f4625fda9f Mon Sep 17 00:00:00 2001 From: Jon Jensen Date: Sun, 12 Nov 2023 12:52:08 -0500 Subject: [PATCH] Don't set GITHUB_TOKEN (#2089) This needs to be explicitly in the `env` to be consistent with GitHub Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- pkg/runner/run_context.go | 1 - pkg/runner/step_test.go | 1 - 2 files changed, 2 deletions(-) diff --git a/pkg/runner/run_context.go b/pkg/runner/run_context.go index faf64e1..a5493f6 100644 --- a/pkg/runner/run_context.go +++ b/pkg/runner/run_context.go @@ -911,7 +911,6 @@ func (rc *RunContext) withGithubEnv(ctx context.Context, github *model.GithubCon env["GITHUB_REF"] = github.Ref env["GITHUB_REF_NAME"] = github.RefName env["GITHUB_REF_TYPE"] = github.RefType - env["GITHUB_TOKEN"] = github.Token env["GITHUB_JOB"] = github.Job env["GITHUB_REPOSITORY_OWNER"] = github.RepositoryOwner env["GITHUB_RETENTION_DAYS"] = github.RetentionDays diff --git a/pkg/runner/step_test.go b/pkg/runner/step_test.go index d08a129..cdb870e 100644 --- a/pkg/runner/step_test.go +++ b/pkg/runner/step_test.go @@ -182,7 +182,6 @@ func TestSetupEnv(t *testing.T) { "GITHUB_RUN_ID": "runId", "GITHUB_RUN_NUMBER": "1", "GITHUB_SERVER_URL": "https://", - "GITHUB_TOKEN": "", "GITHUB_WORKFLOW": "", "INPUT_STEP_WITH": "with-value", "RC_KEY": "rcvalue",