add TODO
This commit is contained in:
parent
e5e4e3a113
commit
06f0ce2f51
1 changed files with 4 additions and 0 deletions
|
@ -63,6 +63,10 @@ func runDaemon(ctx context.Context, configFile *string) func(cmd *cobra.Command,
|
|||
}
|
||||
|
||||
if ls.RequireDocker() {
|
||||
// TODO: if cfg.Container.DockerHost is a TCP socket like "tcp://127.0.0.1:2375"
|
||||
// it will pass the envcheck.CheckIfDockerRunning but can't be mounted to the job container.
|
||||
// In this case, act_runner will mount /var/run/docker.sock by default.
|
||||
|
||||
dockerSocketPath, err := getDockerSocketPath(cfg.Container.DockerHost)
|
||||
if err != nil {
|
||||
return err
|
||||
|
|
Loading…
Add table
Reference in a new issue