From 02e6b732e9ccf7c40c43d68b7bb514692ceafb4f Mon Sep 17 00:00:00 2001
From: momf <m0fqn090310@gmail.com>
Date: Fri, 8 Jun 2018 22:00:18 +0900
Subject: [PATCH 1/2] fix: when text is null, bug can pass validation.
fixed. (maybe?)
---
src/server/api/endpoints/notes/create.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/server/api/endpoints/notes/create.ts b/src/server/api/endpoints/notes/create.ts
index 182359f637..89e72a184e 100644
--- a/src/server/api/endpoints/notes/create.ts
+++ b/src/server/api/endpoints/notes/create.ts
@@ -140,7 +140,7 @@ module.exports = (params, user: ILocalUser, app: IApp) => new Promise(async (res
}
// テキストが無いかつ添付ファイルが無いかつRenoteも無いかつ投票も無かったらエラー
- if (text === undefined && files === null && renote === null && poll === undefined) {
+ if ((text === undefined or text === null) && files === null && renote === null && poll === undefined) {
return rej('text, mediaIds, renoteId or poll is required');
}
From 33495b5cb327df1d02b728854bf93b3dc3188b9c Mon Sep 17 00:00:00 2001
From: momf <m0fqn090310@gmail.com>
Date: Fri, 8 Jun 2018 22:04:07 +0900
Subject: [PATCH 2/2] fix: "or" operator.
---
src/server/api/endpoints/notes/create.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/server/api/endpoints/notes/create.ts b/src/server/api/endpoints/notes/create.ts
index 89e72a184e..446764e1d6 100644
--- a/src/server/api/endpoints/notes/create.ts
+++ b/src/server/api/endpoints/notes/create.ts
@@ -140,7 +140,7 @@ module.exports = (params, user: ILocalUser, app: IApp) => new Promise(async (res
}
// テキストが無いかつ添付ファイルが無いかつRenoteも無いかつ投票も無かったらエラー
- if ((text === undefined or text === null) && files === null && renote === null && poll === undefined) {
+ if ((text === undefined || text === null) && files === null && renote === null && poll === undefined) {
return rej('text, mediaIds, renoteId or poll is required');
}