From 8785e1c3a48487152dcfc754506e7e86a28a1048 Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Sun, 22 Aug 2021 13:16:15 +0900 Subject: [PATCH 1/9] =?UTF-8?q?enhance(client):=20=E3=83=A6=E3=83=BC?= =?UTF-8?q?=E3=82=B6=E3=83=BC=E5=90=8D=E3=81=AB=E3=81=A4=E3=81=84=E3=81=A6?= =?UTF-8?q?=E3=81=AE=E3=83=92=E3=83=B3=E3=83=88=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- locales/ja-JP.yml | 1 + src/client/components/dialog.vue | 1 + src/client/components/signup.vue | 2 +- src/client/directives/tooltip.ts | 16 +++++++++++++++- src/client/style.scss | 7 +++++++ 5 files changed, 25 insertions(+), 2 deletions(-) diff --git a/locales/ja-JP.yml b/locales/ja-JP.yml index 35739d276..0c78ea149 100644 --- a/locales/ja-JP.yml +++ b/locales/ja-JP.yml @@ -778,6 +778,7 @@ whatIsNew: "更新情報を見る" translate: "翻訳" translatedFrom: "{x}から翻訳" accountDeletionInProgress: "アカウントの削除が進行中です" +usernameInfo: "サーバー上であなたのアカウントを一意に識別するための名前。アルファベット(a~z, A~Z)、数字(0~9)、およびアンダーバー(_)が使用できます。ユーザー名は後から変更することは出来ません。" _accountDelete: accountDelete: "アカウントの削除" diff --git a/src/client/components/dialog.vue b/src/client/components/dialog.vue index f3611f050..0a7508aee 100644 --- a/src/client/components/dialog.vue +++ b/src/client/components/dialog.vue @@ -10,6 +10,7 @@ <i v-else-if="type === 'warning'" class="fas fa-exclamation-triangle"></i> <i v-else-if="type === 'info'" class="fas fa-info-circle"></i> <i v-else-if="type === 'question'" class="fas fa-question-circle"></i> + <i v-else-if="type === 'help'" class="fas fa-question-circle"></i> <i v-else-if="type === 'waiting'" class="fas fa-spinner fa-pulse"></i> </div> <header v-if="title"><Mfm :text="title"/></header> diff --git a/src/client/components/signup.vue b/src/client/components/signup.vue index b0b0c2ad4..a19b4f5bd 100644 --- a/src/client/components/signup.vue +++ b/src/client/components/signup.vue @@ -6,7 +6,7 @@ <template #prefix><i class="fas fa-key"></i></template> </MkInput> <MkInput v-model="username" type="text" pattern="^[a-zA-Z0-9_]{1,20}$" :autocomplete="Math.random()" spellcheck="false" required @update:modelValue="onChangeUsername" data-cy-signup-username> - <template #label>{{ $ts.username }}</template> + <template #label>{{ $ts.username }} <div class="_button _help" v-tooltip:dialog="$ts.usernameInfo"><i class="far fa-question-circle"></i></div></template> <template #prefix>@</template> <template #suffix>@{{ host }}</template> <template #caption> diff --git a/src/client/directives/tooltip.ts b/src/client/directives/tooltip.ts index 90247eacb..cf6f3c8e6 100644 --- a/src/client/directives/tooltip.ts +++ b/src/client/directives/tooltip.ts @@ -1,6 +1,6 @@ import { Directive, ref } from 'vue'; import { isDeviceTouch } from '@client/scripts/is-device-touch'; -import { popup } from '@client/os'; +import { popup, dialog } from '@client/os'; const start = isDeviceTouch ? 'touchstart' : 'mouseover'; const end = isDeviceTouch ? 'touchend' : 'mouseleave'; @@ -24,6 +24,20 @@ export default { } }; + console.log(binding.arg); + + if (binding.arg === 'dialog') { + el.addEventListener('click', (ev) => { + ev.preventDefault(); + ev.stopPropagation(); + dialog({ + type: 'help', + text: binding.value, + }); + return false; + }); + } + const show = e => { if (!document.body.contains(el)) return; if (self._close) return; diff --git a/src/client/style.scss b/src/client/style.scss index a6c027745..269cf8893 100644 --- a/src/client/style.scss +++ b/src/client/style.scss @@ -156,8 +156,10 @@ hr { ._button { appearance: none; + display: inline-block; padding: 0; margin: 0; // for Safari + width: max-content; background: none; border: none; cursor: pointer; @@ -201,6 +203,11 @@ hr { } } +._help { + color: var(--accent); + cursor: help +} + ._textButton { @extend ._button; color: var(--accent); From 98f1d936280737516d3da6770893b1aa9a28df0f Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Sun, 22 Aug 2021 13:16:23 +0900 Subject: [PATCH 2/9] refactor --- src/client/os.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/client/os.ts b/src/client/os.ts index 284f982f0..1e1d950a1 100644 --- a/src/client/os.ts +++ b/src/client/os.ts @@ -214,7 +214,11 @@ export function modalPageWindow(path: string) { }, {}, 'closed'); } -export function dialog(props: Record<string, any>) { +export function dialog(props: { + type: 'error' | 'info' | 'success' | 'warning' | 'waiting' | 'help'; + title?: string | null; + text?: string | null; +}) { return new Promise((resolve, reject) => { popup(import('@client/components/dialog.vue'), props, { done: result => { From 45fe7547591e85a26f4ec0774acd9ff36effe138 Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Sun, 22 Aug 2021 16:15:40 +0900 Subject: [PATCH 3/9] :art: --- CHANGELOG.md | 7 +++++++ src/client/components/signup.vue | 8 ++++---- src/client/directives/tooltip.ts | 2 -- src/client/pages/about-misskey.vue | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fddba3487..8a3988d02 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,13 @@ --> +## 12.x.x (unreleased) + +### Improvements +- クライアントのデザインの調整 + +### Bugfixes + ## 12.89.0 (2021/08/21) ### Improvements diff --git a/src/client/components/signup.vue b/src/client/components/signup.vue index a19b4f5bd..d584b9720 100644 --- a/src/client/components/signup.vue +++ b/src/client/components/signup.vue @@ -1,11 +1,11 @@ <template> -<form class="mk-signup" @submit.prevent="onSubmit" :autocomplete="Math.random()"> +<form class="qlvuhzng" @submit.prevent="onSubmit" :autocomplete="Math.random()"> <template v-if="meta"> - <MkInput v-if="meta.disableRegistration" v-model="invitationCode" type="text" :autocomplete="Math.random()" spellcheck="false" required> + <MkInput class="_inputNoTopMargin" v-if="meta.disableRegistration" v-model="invitationCode" type="text" :autocomplete="Math.random()" spellcheck="false" required> <template #label>{{ $ts.invitationCode }}</template> <template #prefix><i class="fas fa-key"></i></template> </MkInput> - <MkInput v-model="username" type="text" pattern="^[a-zA-Z0-9_]{1,20}$" :autocomplete="Math.random()" spellcheck="false" required @update:modelValue="onChangeUsername" data-cy-signup-username> + <MkInput class="_inputNoTopMargin" v-model="username" type="text" pattern="^[a-zA-Z0-9_]{1,20}$" :autocomplete="Math.random()" spellcheck="false" required @update:modelValue="onChangeUsername" data-cy-signup-username> <template #label>{{ $ts.username }} <div class="_button _help" v-tooltip:dialog="$ts.usernameInfo"><i class="far fa-question-circle"></i></div></template> <template #prefix>@</template> <template #suffix>@{{ host }}</template> @@ -204,7 +204,7 @@ export default defineComponent({ </script> <style lang="scss" scoped> -.mk-signup { +.qlvuhzng { .captcha { margin: 16px 0; } diff --git a/src/client/directives/tooltip.ts b/src/client/directives/tooltip.ts index cf6f3c8e6..b45321660 100644 --- a/src/client/directives/tooltip.ts +++ b/src/client/directives/tooltip.ts @@ -24,8 +24,6 @@ export default { } }; - console.log(binding.arg); - if (binding.arg === 'dialog') { el.addEventListener('click', (ev) => { ev.preventDefault(); diff --git a/src/client/pages/about-misskey.vue b/src/client/pages/about-misskey.vue index a324ebce5..384c7e8cc 100644 --- a/src/client/pages/about-misskey.vue +++ b/src/client/pages/about-misskey.vue @@ -60,7 +60,7 @@ import FormBase from '@client/components/form/base.vue'; import FormGroup from '@client/components/form/group.vue'; import FormKeyValueView from '@client/components/form/key-value-view.vue'; import MkLink from '@client/components/link.vue'; -import { physics } from '@client/scripts/physics.ts'; +import { physics } from '@client/scripts/physics'; import * as symbols from '@client/symbols'; const patrons = [ From f64d3942d7b3528557aa5aedb58d7f633b6e716b Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Sun, 22 Aug 2021 16:18:53 +0900 Subject: [PATCH 4/9] :art: --- src/client/components/dialog.vue | 1 - src/client/directives/tooltip.ts | 2 +- src/client/os.ts | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/client/components/dialog.vue b/src/client/components/dialog.vue index 0a7508aee..f3611f050 100644 --- a/src/client/components/dialog.vue +++ b/src/client/components/dialog.vue @@ -10,7 +10,6 @@ <i v-else-if="type === 'warning'" class="fas fa-exclamation-triangle"></i> <i v-else-if="type === 'info'" class="fas fa-info-circle"></i> <i v-else-if="type === 'question'" class="fas fa-question-circle"></i> - <i v-else-if="type === 'help'" class="fas fa-question-circle"></i> <i v-else-if="type === 'waiting'" class="fas fa-spinner fa-pulse"></i> </div> <header v-if="title"><Mfm :text="title"/></header> diff --git a/src/client/directives/tooltip.ts b/src/client/directives/tooltip.ts index b45321660..ee690558a 100644 --- a/src/client/directives/tooltip.ts +++ b/src/client/directives/tooltip.ts @@ -29,7 +29,7 @@ export default { ev.preventDefault(); ev.stopPropagation(); dialog({ - type: 'help', + type: 'info', text: binding.value, }); return false; diff --git a/src/client/os.ts b/src/client/os.ts index 1e1d950a1..812533279 100644 --- a/src/client/os.ts +++ b/src/client/os.ts @@ -215,7 +215,7 @@ export function modalPageWindow(path: string) { } export function dialog(props: { - type: 'error' | 'info' | 'success' | 'warning' | 'waiting' | 'help'; + type: 'error' | 'info' | 'success' | 'warning' | 'waiting'; title?: string | null; text?: string | null; }) { From dad6a7764542d125c8e3ee41c195fd732c3973f5 Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Sun, 22 Aug 2021 22:22:53 +0900 Subject: [PATCH 5/9] refactoring --- src/client/init.ts | 5 +---- src/server/web/boot.js | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/client/init.ts b/src/client/init.ts index 194ece886..4d2170e03 100644 --- a/src/client/init.ts +++ b/src/client/init.ts @@ -101,15 +101,12 @@ window.addEventListener('resize', () => { }); //#endregion -// Get the <head> element -const head = document.getElementsByTagName('head')[0]; - // If mobile, insert the viewport meta tag if (isMobile || window.innerWidth <= 1024) { const viewport = document.getElementsByName('viewport').item(0); viewport.setAttribute('content', `${viewport.getAttribute('content')},minimum-scale=1,maximum-scale=1,user-scalable=no`); - head.appendChild(viewport); + document.head.appendChild(viewport); } //#region Set lang attr diff --git a/src/server/web/boot.js b/src/server/web/boot.js index e2fd137f9..7a41ae255 100644 --- a/src/server/web/boot.js +++ b/src/server/web/boot.js @@ -60,8 +60,6 @@ ? `?salt=${localStorage.getItem('salt')}` : ''; - const head = document.getElementsByTagName('head')[0]; - const script = document.createElement('script'); script.setAttribute('src', `/assets/app.${v}.js${salt}`); script.setAttribute('async', 'true'); @@ -70,7 +68,7 @@ renderError('APP_FETCH_FAILED'); checkUpdate(); }); - head.appendChild(script); + document.head.appendChild(script); //#endregion //#region Theme From 9d3448c880c0b2b3fec2f8acf68cf4cc472ee81a Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Tue, 24 Aug 2021 13:08:20 +0900 Subject: [PATCH 6/9] fix(server): use csp to imporve security --- CHANGELOG.md | 1 + src/server/file/index.ts | 4 ++++ src/server/proxy/index.ts | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a3988d02..5e4fbbf36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - クライアントのデザインの調整 ### Bugfixes +- セキュリティの向上 ## 12.89.0 (2021/08/21) diff --git a/src/server/file/index.ts b/src/server/file/index.ts index 9b5d8f726..a455acd1c 100644 --- a/src/server/file/index.ts +++ b/src/server/file/index.ts @@ -17,6 +17,10 @@ const _dirname = dirname(_filename); // Init app const app = new Koa(); app.use(cors()); +app.use(async (ctx, next) => { + ctx.set('Content-Security-Policy', `default-src 'none'; style-src 'unsafe-inline'`); + await next(); +}); // Init router const router = new Router(); diff --git a/src/server/proxy/index.ts b/src/server/proxy/index.ts index 9ef198d31..b8993f19f 100644 --- a/src/server/proxy/index.ts +++ b/src/server/proxy/index.ts @@ -10,6 +10,10 @@ import { proxyMedia } from './proxy-media'; // Init app const app = new Koa(); app.use(cors()); +app.use(async (ctx, next) => { + ctx.set('Content-Security-Policy', `default-src 'none'; style-src 'unsafe-inline'`); + await next(); +}); // Init router const router = new Router(); From c4707c612d4e1f5cd63209fd93d6f0395674aa85 Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Tue, 24 Aug 2021 13:08:58 +0900 Subject: [PATCH 7/9] New Crowdin updates (#7679) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations create-plugin.md (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Esperanto) * New translations keyboard-shortcut.md (Esperanto) * New translations timeline.md (Esperanto) * New translations glossary.md (Esperanto) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Esperanto) * New translations keyboard-shortcut.md (Esperanto) * New translations timeline.md (Esperanto) * New translations glossary.md (Esperanto) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Korean) --- locales/de-DE.yml | 1 + locales/en-US.yml | 1 + locales/eo-UY.yml | 22 +++++++++++++++++----- locales/ko-KR.yml | 9 +++++++++ locales/zh-CN.yml | 5 +++++ src/docs/eo-UY/advanced/create-plugin.md | 2 +- 6 files changed, 34 insertions(+), 6 deletions(-) diff --git a/locales/de-DE.yml b/locales/de-DE.yml index 0fcfc9b46..1afc8fab4 100644 --- a/locales/de-DE.yml +++ b/locales/de-DE.yml @@ -778,6 +778,7 @@ whatIsNew: "Änderungen anzeigen" translate: "Übersetzen" translatedFrom: "Aus {x} übersetzt" accountDeletionInProgress: "Löschung des Benutzerkontos momentan in Bearbeitung" +usernameInfo: "Ein Name, durch den dein Benutzerkonto auf diesem Server identifiziert werden kann. Du kannst das Alphabet (a~z, A~Z), Ziffern (0~9) oder Unterstriche (_) verwenden. Benutzernamen können später nicht geändert werden." _accountDelete: accountDelete: "Benutzerkonto löschen" mayTakeTime: "Da die Löschung eines Benutzerkontos ein aufwendiger Prozess ist, kann dessen Dauer davon abhängen, wie viel Inhalt in diesem erstellt wurde oder wie viele Dateien hochgeladen wurden." diff --git a/locales/en-US.yml b/locales/en-US.yml index cf82a8cd7..9565e6203 100644 --- a/locales/en-US.yml +++ b/locales/en-US.yml @@ -778,6 +778,7 @@ whatIsNew: "Show changes" translate: "Translate" translatedFrom: "Translated from {x}" accountDeletionInProgress: "Account deletion is currently in progress" +usernameInfo: "A name that identifies your account from others on this server. You can use the alphabet (a~z, A~Z), digits (0~9) or underscores (_). Usernames can not be changed later." _accountDelete: accountDelete: "Delete Account" mayTakeTime: "As account deletion is a resource-heavy process, it may take some time to complete depending on how much content you have created and how many files you have uploaded." diff --git a/locales/eo-UY.yml b/locales/eo-UY.yml index bb141a692..4d435512b 100644 --- a/locales/eo-UY.yml +++ b/locales/eo-UY.yml @@ -73,6 +73,7 @@ following: "Sekvatoj" followers: "Sekvantoj" followsYou: "Sekvas vin" createList: "Kreii liston" +manageLists: "Administri liston" error: "Eraro" somethingHappened: "Problemo okazis." retry: "Reprovi" @@ -188,7 +189,7 @@ fromUrl: "De URL" uploadFromUrl: "Alŝuti de URL" uploadFromUrlDescription: "URL de la dosiero kiun vi volas alŝuti" explore: "Esplori" -games: "Ludoj sur Misskey" +games: "Miskiaj Ludoj" messageRead: "Legita" startMessaging: "Komenci babiladon" nUsersRead: "Legita de {n} homoj" @@ -245,6 +246,7 @@ yearX: "La jaro {year}" pages: "Paĝoj" connectService: "Konekti" disconnectService: "Farkonektiĝi" +enableLocalTimeline: "Ebligi lokan templinion" enableGlobalTimeline: "Ebligi mallokan templinion" registration: "Registri" driveCapacityPerLocalAccount: "Volumo de disko po unu loka uzanto" @@ -257,6 +259,7 @@ pinnedUsers: "Alpinglita uzanto" pinnedPages: "Alpinglitaj paĝoj" pinnedNotes: "Pinglita noto" antennas: "Antenoj" +manageAntennas: "Administri antenojn" name: "Nomo" withFileAntenna: "Nur kun aldonaĵo" withReplies: "Inkluzive respondoj" @@ -342,6 +345,7 @@ poll: "Balotujo" useCw: "Kaŝi enhavo" themeEditor: "Redaktilo de koloraroj" author: "Aŭtoro" +manage: "Administro" plugins: "Kromaĵoj" deck: "Kartaro" medium: "Meza" @@ -424,6 +428,7 @@ offline: "Forkonektita" instanceBlocking: "Blokado de ekzemplo" selectAccount: "Elekti konton" user: "Uzanto" +administration: "Administro" accounts: "Kontoj" high: "Alta" middle: "Meza" @@ -440,6 +445,7 @@ translatedFrom: "Tradukita el {x}" _docs: continueReading: "Legi plu" features: "Funkcioj" + admin: "Administro" _gallery: liked: "Ŝatitaj notoj" like: "Ŝati" @@ -448,6 +454,9 @@ _email: title: "Vi estas eksekvita" _receiveFollowRequest: title: "Vi ricevis peton de sekvado" +_plugin: + install: "Instali kromaĵon" + manage: "Administri kromaĵojn" _registry: key: "Ŝlosilo" keys: "Ŝlosiloj" @@ -461,6 +470,7 @@ _aboutMisskey: translation: "Traduki Misskey'on" patrons: "Mecenatoj" _mfm: + dummy: "Misskey vastigas la mondon de Fediverso" mention: "Mencioj" hashtag: "Kradvorto" url: "URL" @@ -488,6 +498,7 @@ _instanceTicker: _channel: create: "Krei kanalon" edit: "Redakti kanalon" + owned: "Posedaĵo" following: "Sekvante" usersCount: "{n} partoprenanto(j)" _menuDisplay: @@ -496,6 +507,7 @@ _wordMute: muteWords: "Kaŝigitaj vortoj" mutedNotes: "Silentigataj notoj" _theme: + manage: "Administri kolorarojn" code: "Kodo de koloraro" darken: "Malbrileco" lighten: "Brileco" @@ -612,10 +624,10 @@ _charts: federationInstancesTotal: "Tuta numero de kunfederantaj ekzemploj" filesTotal: "Tuta numero de dosieroj" _timelines: - home: "Hejmo" - local: "Loka" - social: "Sociala" - global: "Malloka" + home: "HEJMO" + local: "LOKA" + social: "SOCIALA" + global: "MALLOKA" _rooms: translate: "Movi" chooseImage: "Elekti bildon" diff --git a/locales/ko-KR.yml b/locales/ko-KR.yml index 99fc0ba6f..43e01fc2c 100644 --- a/locales/ko-KR.yml +++ b/locales/ko-KR.yml @@ -777,6 +777,15 @@ misskeyUpdated: "Misskey가 업데이트 되었습니다!" whatIsNew: "패치 정보 보기" translate: "번역" translatedFrom: "{x}에서 번역" +accountDeletionInProgress: "계정 삭제 작업을 진행하고 있습니다" +usernameInfo: "서버상에서 계정을 식별하기 위한 이름. 알파벳(a~z, A~Z), 숫자(0~9) 및 언더바(_)를 사용할 수 있습니다. 사용자명은 나중에 변경할 수 없습니다." +_accountDelete: + accountDelete: "계정 삭제" + mayTakeTime: "계정 삭제는 서버에 부하를 가하기 때문에, 작성한 콘텐츠나 업로드한 파일의 수가 많으면 완료까지 시간이 걸릴 수 있습니다." + sendEmail: "계정 삭제가 완료되면 등록된 이메일 주소로 알림을 보냅니다." + requestAccountDelete: "계정 삭제 요청" + started: "삭제 작업이 시작되었습니다." + inProgress: "삭제 진행 중" _docs: continueReading: "계속 읽기" features: "기능" diff --git a/locales/zh-CN.yml b/locales/zh-CN.yml index aad08d1b4..7dad6232b 100644 --- a/locales/zh-CN.yml +++ b/locales/zh-CN.yml @@ -777,6 +777,11 @@ misskeyUpdated: "Misskey更新完成!" whatIsNew: "显示更新信息" translate: "翻译" translatedFrom: "从 {x} 翻译" +accountDeletionInProgress: "正在删除账户" +usernameInfo: "在服务器上唯一标识您的帐户的名称。您可以使用字母 (a ~ z, A ~ Z)、数字 (0 ~ 9) 和下划线 (_)。用户名以后不能更改。" +_accountDelete: + accountDelete: "删除帐户" + inProgress: "正在删除" _docs: continueReading: "继续阅读" features: "特性" diff --git a/src/docs/eo-UY/advanced/create-plugin.md b/src/docs/eo-UY/advanced/create-plugin.md index 0d2fa1917..2a5af7291 100644 --- a/src/docs/eo-UY/advanced/create-plugin.md +++ b/src/docs/eo-UY/advanced/create-plugin.md @@ -5,7 +5,7 @@ Misskey Webクライアントのプラグイン機能を使うと、クライア プラグインは、AiScriptのメタデータ埋め込み機能を使って、デフォルトとしてプラグインのメタデータを定義する必要があります。 メタデータは次のプロパティを含むオブジェクトです。 ### name -プラグイン名 +Nomo de kromaĵo ### author プラグイン作者 From d64e25e4490da7fc508230d92d277b1c5284b381 Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Tue, 24 Aug 2021 13:19:21 +0900 Subject: [PATCH 8/9] fix: support DeepL pro account Fix #7648 --- CHANGELOG.md | 2 ++ migration/1629778475000-deepl-integration2.ts | 14 ++++++++++++++ src/client/pages/instance/other-settings.vue | 6 ++++++ src/models/entities/meta.ts | 5 +++++ src/server/api/endpoints/admin/update-meta.ts | 8 ++++++++ src/server/api/endpoints/meta.ts | 2 ++ src/server/api/endpoints/notes/translate.ts | 4 +++- 7 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 migration/1629778475000-deepl-integration2.ts diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e4fbbf36..1cf0d5fa7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ - クライアントのデザインの調整 ### Bugfixes +- 翻訳でDeepLのProアカウントに対応していない問題を修正 +- インスタンス設定でDeepLのAuth Keyが空で表示される問題を修正 - セキュリティの向上 ## 12.89.0 (2021/08/21) diff --git a/migration/1629778475000-deepl-integration2.ts b/migration/1629778475000-deepl-integration2.ts new file mode 100644 index 000000000..67e5ea02a --- /dev/null +++ b/migration/1629778475000-deepl-integration2.ts @@ -0,0 +1,14 @@ +import {MigrationInterface, QueryRunner} from "typeorm"; + +export class deeplIntegration21629778475000 implements MigrationInterface { + name = 'deeplIntegration21629778475000' + + public async up(queryRunner: QueryRunner): Promise<void> { + await queryRunner.query(`ALTER TABLE "meta" ADD "deeplIsPro" boolean NOT NULL DEFAULT false`); + } + + public async down(queryRunner: QueryRunner): Promise<void> { + await queryRunner.query(`ALTER TABLE "meta" DROP COLUMN "deeplIsPro"`); + } + +} diff --git a/src/client/pages/instance/other-settings.vue b/src/client/pages/instance/other-settings.vue index 800252893..4fa80b2b2 100644 --- a/src/client/pages/instance/other-settings.vue +++ b/src/client/pages/instance/other-settings.vue @@ -12,6 +12,9 @@ <template #prefix><i class="fas fa-key"></i></template> DeepL Auth Key </FormInput> + <FormSwitch v-model:value="deeplIsPro"> + Pro account + </FormSwitch> </FormGroup> <FormButton @click="save" primary><i class="fas fa-save"></i> {{ $ts.save }}</FormButton> </FormSuspense> @@ -50,6 +53,7 @@ export default defineComponent({ }, summalyProxy: '', deeplAuthKey: '', + deeplIsPro: false, } }, @@ -62,11 +66,13 @@ export default defineComponent({ const meta = await os.api('meta', { detail: true }); this.summalyProxy = meta.summalyProxy; this.deeplAuthKey = meta.deeplAuthKey; + this.deeplIsPro = meta.deeplIsPro; }, save() { os.apiWithDialog('admin/update-meta', { summalyProxy: this.summalyProxy, deeplAuthKey: this.deeplAuthKey, + deeplIsPro: this.deeplIsPro, }).then(() => { fetchInstance(); }); diff --git a/src/models/entities/meta.ts b/src/models/entities/meta.ts index 2a0632c87..6428aacdf 100644 --- a/src/models/entities/meta.ts +++ b/src/models/entities/meta.ts @@ -319,6 +319,11 @@ export class Meta { }) public deeplAuthKey: string | null; + @Column('boolean', { + default: false, + }) + public deeplIsPro: boolean; + @Column('varchar', { length: 512, nullable: true diff --git a/src/server/api/endpoints/admin/update-meta.ts b/src/server/api/endpoints/admin/update-meta.ts index 5962dba98..46f30fef7 100644 --- a/src/server/api/endpoints/admin/update-meta.ts +++ b/src/server/api/endpoints/admin/update-meta.ts @@ -149,6 +149,10 @@ export const meta = { validator: $.optional.nullable.str, }, + deeplIsPro: { + validator: $.optional.bool, + }, + enableTwitterIntegration: { validator: $.optional.bool, }, @@ -574,6 +578,10 @@ export default define(meta, async (ps, me) => { } } + if (ps.deeplIsPro !== undefined) { + set.deeplIsPro = ps.deeplIsPro; + } + await getConnection().transaction(async transactionalEntityManager => { const meta = await transactionalEntityManager.findOne(Meta, { order: { diff --git a/src/server/api/endpoints/meta.ts b/src/server/api/endpoints/meta.ts index 1c87952f6..3f422dff0 100644 --- a/src/server/api/endpoints/meta.ts +++ b/src/server/api/endpoints/meta.ts @@ -583,6 +583,8 @@ export default define(meta, async (ps, me) => { response.objectStorageUseProxy = instance.objectStorageUseProxy; response.objectStorageSetPublicRead = instance.objectStorageSetPublicRead; response.objectStorageS3ForcePathStyle = instance.objectStorageS3ForcePathStyle; + response.deeplAuthKey = instance.deeplAuthKey; + response.deeplIsPro = instance.deeplIsPro; } } diff --git a/src/server/api/endpoints/notes/translate.ts b/src/server/api/endpoints/notes/translate.ts index a5fdf70ce..e4bc6bb06 100644 --- a/src/server/api/endpoints/notes/translate.ts +++ b/src/server/api/endpoints/notes/translate.ts @@ -61,7 +61,9 @@ export default define(meta, async (ps, user) => { params.append('text', note.text); params.append('target_lang', targetLang); - const res = await fetch('https://api-free.deepl.com/v2/translate', { + const endpoint = instance.deeplIsPro ? 'https://api.deepl.com/v2/translate' : 'https://api-free.deepl.com/v2/translate'; + + const res = await fetch(endpoint, { method: 'POST', headers: { 'Content-Type': 'application/x-www-form-urlencoded', From c3b55b6849bd2d7d562ff128cb4167d6d2add9da Mon Sep 17 00:00:00 2001 From: syuilo <Syuilotan@yahoo.co.jp> Date: Tue, 24 Aug 2021 13:20:20 +0900 Subject: [PATCH 9/9] 12.89.1 --- CHANGELOG.md | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1cf0d5fa7..7e8add521 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ --> -## 12.x.x (unreleased) +## 12.89.1 (2021/08/24) ### Improvements - クライアントのデザインの調整 diff --git a/package.json b/package.json index 7754fb928..b085bf1c8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "misskey", "author": "syuilo <syuilotan@yahoo.co.jp>", - "version": "12.89.0", + "version": "12.89.1", "codename": "indigo", "repository": { "type": "git",