act/pkg/runner/testdata/job-status-check/push.yml

on: push
jobs:
  fail:
    runs-on: ubuntu-latest
    steps:
    - run: exit 1
  suc1:
    if: success() || failure()
    needs:
    - fail
    runs-on: ubuntu-latest
    steps:
    - run: exit 0
  suc2:
    if: success() || failure()
    needs:
    - fail
    runs-on: ubuntu-latest
    steps:
    - run: exit 0
  next:
    needs:
    - suc1
    - suc2
    runs-on: ubuntu-latest
    steps:
    - run: echo should never reach here
    - run: exit 1
fix: continue jobs + steps after failure (#840) * fix: continue jobs + steps after failure To allow proper if expression handling on jobs and steps (like always, success, failure, ...) we need to continue running all executors in the prepared chain. To keep the error handling intact we add an occurred error to the go context and handle it later in the pipeline/chain. Also we add the job result to the needs context to give expressions access to it. The needs object, failure and success functions are split between run context (on jobs) and step context. Closes #442 Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de> * style: correct linter warnings Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de> * fix: job if value defaults to success() As described in the documentation, a default value of "success()" is applied when no "if" value is present on the job. https://docs.github.com/en/actions/learn-github-actions/expressions#job-status-check-functions Co-authored-by: Markus Wolf <mail@markus-wolf.de> * fix: check job needs recursively Ensure job result includes results of previous jobs Co-authored-by: Markus Wolf <markus.wolf@new-work.se> * test: add runner test for job status check functions Co-authored-by: Markus Wolf <markus.wolf@new-work.se> * test: add unit tests for run context if evaluation Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de> * refactor: move if expression evaluation Move if expression evaluation into own function (step context) to better support unit testing. Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de> * test: add unit tests for step context if evaluation Co-authored-by: Markus Wolf <markus.wolf@new-work.se> * fix: handle job error more resilient The job error is not stored in a context map instead of a context added value. Since context values are immutable an added value requires to keep the new context in all cases. This is fragile since it might slip unnoticed to other parts of the code. Storing the error of a job in the context map will make it more stable, since the map is always there and the context of the pipeline is stable for the whole run. * feat: steps should use a default if expression of success() * test: add integration test for if-expressions * chore: disable editorconfig-checker for yaml multiline string Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de> Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se> 2021-12-08 14:57:42 -06:00			`on: push`
			`jobs:`
			`fail:`
			`runs-on: ubuntu-latest`
			`steps:`
			`- run: exit 1`
			`suc1:`
			`if: success() \|\| failure()`
			`needs:`
			`- fail`
			`runs-on: ubuntu-latest`
			`steps:`
			`- run: exit 0`
			`suc2:`
			`if: success() \|\| failure()`
			`needs:`
			`- fail`
			`runs-on: ubuntu-latest`
			`steps:`
			`- run: exit 0`
			`next:`
			`needs:`
			`- suc1`
			`- suc2`
			`runs-on: ubuntu-latest`
			`steps:`
			`- run: echo should never reach here`
			`- run: exit 1`