yume/act
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: keep action inputs (#1215)

Browse source 
Do not initialize inputs a second time (in pre and main step).
When the action setup already run during pre step, we must not
re-run it during the main step, otherwise the inputs will be
overwritten by possible other action inputs.
This commit is contained in:
Markus Wolf 2022-06-20 23:58:51 +02:00 committed by GitHub
parent 4391a10d5a
commit 1d4c2aaa3f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 56 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/runner/step_action_remote.go
View file

@ -36,8 +36,7 @@ var (
) )
func (sar *stepActionRemote) prepareActionExecutor() common.Executor { func (sar *stepActionRemote) prepareActionExecutor() common.Executor {
return common.NewPipelineExecutor( return func(ctx context.Context) error {
func(ctx context.Context) error {
if sar.remoteAction != nil && sar.action != nil { if sar.remoteAction != nil && sar.action != nil {
// we are already good to run // we are already good to run
return nil return nil
@ -89,12 +88,12 @@ func (sar *stepActionRemote) prepareActionExecutor() common.Executor {
sar.action = actionModel sar.action = actionModel
return err return err
}, },
)(ctx)
},
func(ctx context.Context) error { func(ctx context.Context) error {
sar.RunContext.setupActionInputs(ctx, sar) sar.RunContext.setupActionInputs(ctx, sar)
return nil return nil
}) },
)(ctx)
}
} }
func (sar *stepActionRemote) pre() common.Executor { func (sar *stepActionRemote) pre() common.Executor {