yume/act
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: remove unnecessary nil check in RunContext (#1955)

Browse source 
From the Go docs:

  "For a nil slice, the number of iterations is 0" [1]

Therefore, an additional nil check for `job.RunsOn()` before the loop is
unnecessary because `job.RunsOn()` returns a `[]string`.

[1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun 2023-08-09 20:41:12 +08:00 committed by GitHub
parent a42f3cf1cd
commit 8a9e4f9f38
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
pkg/runner/run_context.go
View file

@ -789,17 +789,15 @@ func (rc *RunContext) withGithubEnv(ctx context.Context, github *model.GithubCon
} }
job := rc.Run.Job() job := rc.Run.Job()
if job.RunsOn() != nil { for _, runnerLabel := range job.RunsOn() {
for _, runnerLabel := range job.RunsOn() { platformName := rc.ExprEval.Interpolate(ctx, runnerLabel)
platformName := rc.ExprEval.Interpolate(ctx, runnerLabel) if platformName != "" {
if platformName != "" { if platformName == "ubuntu-latest" {
if platformName == "ubuntu-latest" { // hardcode current ubuntu-latest since we have no way to check that 'on the fly'
// hardcode current ubuntu-latest since we have no way to check that 'on the fly' env["ImageOS"] = "ubuntu20"
env["ImageOS"] = "ubuntu20" } else {
} else { platformName = strings.SplitN(strings.Replace(platformName, `-`, ``, 1), `.`, 2)[0]
platformName = strings.SplitN(strings.Replace(platformName, `-`, ``, 1), `.`, 2)[0] env["ImageOS"] = platformName
env["ImageOS"] = platformName
}
} }
} }
} }