act/pkg/runner
Björn Brauer 9abc87b416
fix: always execute closeContainer() executor (#988)
* fix: always execute closeContainer() executor

During our earlier refactoring in #984 we accidentally changed the
behaviour in such a way that the `closeContainer()` executor was never
called.

This commit restores the earlier behaviour.

Ref:
* https://github.com/nektos/act/pull/984/files#diff-c057d66dc9657d8428e290c69871596e2b567bb8fecad62a99cab54398131a84L294
* https://github.com/nektos/act/pull/984/files#diff-ea9d5c93d769ef9b268932dd9990363e97fc3bec8a00114979d049bead5dd718R68

* test: add testcases to ensure job containers are started/stopped

This commit adds tests to ensure that the executors of `startContainer`,
`stopContainer`, `interpolateOutputs` and `closeContainer` are always
called in the correct order.
2022-02-10 16:54:58 +00:00
..
res Add super-linter + fix lint issues (#650) 2021-05-03 09:52:03 -07:00
testdata Fix: regression run after failure (#971) 2022-01-27 16:20:44 +00:00
action.go refactor: extract setupAction into ActionReader (#986) 2022-02-08 20:17:59 +00:00
action_test.go refactor: extract setupAction into ActionReader (#986) 2022-02-08 20:17:59 +00:00
command.go fix: ::stop-commands:: should continue to print the lines (#920) 2021-12-09 15:10:56 +00:00
command_test.go refactor: export and move shared contexts into pkg/model (#931) 2021-12-22 19:52:09 +00:00
expression.go Refactor expression evaluator to use parser from actionlint package (#908) 2022-01-21 08:07:20 -08:00
expression_test.go Refactor expression evaluator to use parser from actionlint package (#908) 2022-01-21 08:07:20 -08:00
job_executor.go fix: always execute closeContainer() executor (#988) 2022-02-10 16:54:58 +00:00
job_executor_test.go fix: always execute closeContainer() executor (#988) 2022-02-10 16:54:58 +00:00
logger.go feat: allow existing logger from context (#898) 2021-11-27 17:45:56 +00:00
run_context.go refactor: extract RunContext Executor in JobExecutor (#984) 2022-02-08 17:22:41 +00:00
run_context_test.go Refactor expression evaluator to use parser from actionlint package (#908) 2022-01-21 08:07:20 -08:00
runner.go refactor: export and move shared contexts into pkg/model (#931) 2021-12-22 19:52:09 +00:00
runner_test.go Fix: regression run after failure (#971) 2022-01-27 16:20:44 +00:00
step_context.go refactor: extract setupAction into ActionReader (#986) 2022-02-08 20:17:59 +00:00
step_context_test.go refactor: export and move shared contexts into pkg/model (#931) 2021-12-22 19:52:09 +00:00