Make rust 1.28 minimum supported version (#285)

.travis.yml

@@ -8,8 +8,8 @@ rust:
   - nightly
 
   # Prevent accidentally breaking older Rust versions
-  - 1.23.0
-  - 1.22.0
+  - 1.29.0
+  - 1.28.0
 
 env:
   global:

_build/azure-pipelines-template.yml

@@ -11,9 +11,9 @@ jobs:
       nightly:
         rustup_toolchain: nightly
       minimum_supported_version_plus_one:
-        rustup_toolchain: 1.23.0
+        rustup_toolchain: 1.29.0
       minimum_supported_version:
-        rustup_toolchain: 1.22.0
+        rustup_toolchain: 1.28.0
   steps:
   - ${{ if ne(parameters.name, 'Windows') }}:
     # Linux and macOS.

changelog/master.md

@@ -2,6 +2,10 @@
 
 ## Changes
 
+- The minimum required Rust version is now `1.28.0`.
+
+  [#271](https://github.com/graphql-rust/juniper/pull/271)
+
 - Juniper is now generic about the exact representation of scalar values. This
   allows downstream crates to add support for own scalar value representations.
 

juniper/src/schema/meta.rs

@@ -788,9 +788,9 @@ fn clean_docstring(multiline: &[&str]) -> Option<String> {
                     .map(|ch| ch.is_whitespace())
                     .unwrap_or(false)
                 {
-                    ln.trim_end() // skip trimming the first line
+                    ln.trim_right() // skip trimming the first line
                 } else if ln.len() >= trim_start {
-                    &ln[trim_start..].trim_end()
+                    ln[trim_start..].trim_right()
                 } else {
                     ""
                 };