yume/juniper
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove JSON wrapper object from GraphQLError::to_json

Browse source 
This should be the responsibility of the caller and makes it consistent
with how the successful case is handled.
This commit is contained in:
Michael Macias 2017-01-04 21:37:32 -06:00
parent f33213e17e
commit bd00e6c23d
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/integrations/iron_handlers.rs
View file

@ -108,11 +108,12 @@ impl<'a, CtxFactory, Query, Mutation, CtxT>
let result = execute(query, None, &self.root_node, variables, &context);
let content_type = "application/json".parse::<Mime>().unwrap();
let mut map = BTreeMap::new();
match result {
Ok((result, errors)) => {
let mut map = BTreeMap::new();
map.insert("data".to_owned(), result.to_json());
if !errors.is_empty() {
map.insert("errors".to_owned(), errors.to_json());
}
@ -124,7 +125,9 @@ impl<'a, CtxFactory, Query, Mutation, CtxT>
}
Err(err) => {
let data = err.to_json();
map.insert("errors".to_owned(), err.to_json());
let data = Json::Object(map);
let json = data.pretty();
Ok(Response::with((content_type, status::BadRequest, json.to_string())))

10
src/lib.rs
View file

@ -286,20 +286,16 @@ impl<'a> From<Spanning<ParseError<'a>>> for GraphQLError<'a> {
impl<'a> ToJson for GraphQLError<'a> {
fn to_json(&self) -> Json {
let errs = match *self {
match *self {
GraphQLError::ParseError(ref err) => parse_error_to_json(err),
GraphQLError::ValidationError(ref errs) => errs.to_json(),
GraphQLError::MultipleOperationsProvided => Json::String(
"Must provide operation name if query contains multiple operations.".to_owned()),
"Must provide operation name if query contains multiple operations".to_owned()),
GraphQLError::NoOperationProvided => Json::String(
"Must provide an operation".to_owned()),
GraphQLError::UnknownOperationName => Json::String(
"Unknown operation".to_owned()),
};
Json::Object(vec![
("errors".to_owned(), errs),
].into_iter().collect())
}
}
}